-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GH-9344: pgsql pipeline mode proposal. #10868
Conversation
f2c728b
to
e009802
Compare
ping @kocsismate when you have a moment :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not very familiar with pgsql. It would be nice if someone else could also review the PR
thanks ! cc @Girgias @iluuu1994 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From looking at the documentation this seems ok, but I haven't ever used this 🙂
} | ||
|
||
if (!pg_send_query_params($db, "select $1 as index, now() + ($1||' day')::interval as time", array(1))) { | ||
die('pg_send_query_params{}'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the {}
braces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah :-) in the early versions of the tests I added a value you have good eye :-)
Adding pg_enter_pipeline_mode, pg_exit_pipeline_mode, pg_pipeline_sync and pg_pipeline_status.
a941fce
to
5ac1e3b
Compare
Adding pg_enter_pipeline_mode, pg_exit_pipeline_mode, pg_pipeline_sync and pg_pipeline_status.