Skip to content

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Mar 20, 2023

php_stream_context_set already increases the refcount.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, just requested Jakub's review as he better versed in Streams

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix looks good but the test strategy might be done differently.

`php_stream_context_set` already increases the refcount.
@iluuu1994 iluuu1994 closed this in 122f128 Mar 20, 2023
@iluuu1994
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants