[RFC] Implement Property Capture for Anonymous Classes #11123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC: https://wiki.php.net/rfc/property-capture Adds a "use" clause to anonymous class declarations, which allows capturing local variables by declaring them as properties in the class definition, and passing them into the constructor of each instance. A new AST kind is used to track the list of properties to add and their modifiers (visibility, type, readonly, reference). This is then transformed into a constructor during compilation, piggy-backing on the implementation of Constructor Property Promotion, but using custom error messages and reflectable flags, so that a future implementation could work differently if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/property-capture
Adds a "use" clause to anonymous class declarations, which allows capturing local variables by declaring them as properties in the class definition, and passing them into the constructor of each instance.
A new AST kind is used to track the list of properties to add and their modifiers (visibility, type, readonly, reference). This is then transformed into a constructor during compilation, piggy-backing on the implementation of Constructor Property Promotion, but using custom error messages and reflectable flags, so that a future implementation could work differently if necessary.