Skip to content

Fix GH-11141: Could not open input file: should be sent to stderr #11163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-11141: Could not open input file: should be sent to stderr #11163

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

Closes GH-11141.

I grepped for php_printf cases in main/ and sapi/ and converted the cases which clearly indicate errors to fprintf(stderr, ...), like suggested in the linked issue.

@nielsdos nielsdos requested a review from bukka as a code owner April 29, 2023 19:29
mvorisek
mvorisek reviewed Apr 29, 2023
View reviewed changes
@nielsdos
Fix phpGH-11141: Could not open input file: should be sent to stderr
08b3619 
I grepped for php_printf cases in main/ and sapi/ and converted the
cases which clearly indicate errors to fprintf(stderr, ...), like
suggested in the linked issue.
Girgias
Girgias approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@nielsdos nielsdos closed this in ac5920f May 5, 2023
@pronskiy pronskiy mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

+1 more reviewer

@mvorisek mvorisek mvorisek left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
SAPI: cli SAPI: litespeed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not open input file: should be sent to stderr
3 participants
@nielsdos @mvorisek @Girgias