Bug65872 pass hash key to array reduce cb

[erikjwaxx]

This merge request passes the array key as a third parameter to an array_reduce callback.

[laruence]

You can use ZEND_HASH_FOREACH_KEY_VAL(ht, num, str, val) here, then if str == NULL it's a num key.

[erikjwaxx]

That's a good point. No sense in dereferencing things from the bucket when there are macros to do it for you :).

[laruence]

And also ZVAL_STR(&args[2], zend_string_copy(arr_str_key));

[nikic]

Or ZVAL_STR_COPY(&args[2], arr_str_key).

[laruence]

yeah, this is better

[nikic]

Passing an additional parameter to the reduce callback is a BC break, please open a discussion in the internals mailing list about this.

[krakjoe]

Since this has merge conflicts, and since an internals discussion never materialised, it seems the author has abandoned this proposal, so I'm closing this PR.

Please take this action as encouragement to do as requested, open an internals discussion, if consensus emerges from that, please open a clean PR.