Fix segfault in mb_strrpos/mb_strripos with ASCII encoding and negative offset #11220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve offset We're setting the encoding from PHP_FUNCTION(mb_strpos), but mbfl_strpos would discard it, setting it to mbfl_encoding_pass, making zend_memnrstr fail due to a null-pointer exception. Fixes phpGH-11217
Should expose php#11217
|
Thanks very much! Hope to review this within about 2 days.
…On Wed, May 10, 2023, 3:26 PM Ilija Tovilo ***@***.***> wrote:
@iluuu1994 <https://github.com/iluuu1994> requested your review on: #11220
<#11220> Fix segfault in
mb_strrpos/mb_strripos with ASCII encoding and negative offset.
—
Reply to this email directly, view it on GitHub
<#11220 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIESX6PTVSOL34MJMEGJCLXFOCOXANCNFSM6AAAAAAX4VJNLU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
alexdowad
approved these changes
May 14, 2023
|
Looks good to me. Thanks very much, @iluuu1994. Sorry that I took a couple days more than expected to get to this. |
|
@alexdowad No worries, there's are rarely a hurry. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're setting the encoding from PHP_FUNCTION(mb_strpos), but mbfl_strpos would discard it, setting it to mbfl_encoding_pass, making zend_memnrstr fail due to a null-pointer exception.
Fixes GH-11217