Regression tests for SplFileInfo class setters #1134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for SplFileInfo class setters accepting either the base and child classes, and throwing an exception for unexpected classes. Related: http://svn.php.net/viewvc?view=revision&revision=336017 and facebook/hhvm#4917
jmikola
force-pushed
the
5.4-SplFileInfo_class_setter_tests
branch
from
3088342 to
dea7bc8
Compare
|
Can one of the admins verify this patch? |
|
5.4 is security-only, but I'll merge from 5.5 up, tests shouldn't hurt. |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for SplFileInfo class setters accepting either the base and child classes, and throwing an exception for unexpected classes.
Related: http://svn.php.net/viewvc?view=revision&revision=336017 and facebook/hhvm#4917