Implemented FR #45235 implement error_clear_last() function #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Clear the last occurred error. Returns false if there hasn't been an error yet. */ | ||
| PHP_FUNCTION(error_clear_last) | ||
| { | ||
| if (zend_parse_parameters(ZEND_NUM_ARGS(), "") == FAILURE) { |
There was a problem hiding this comment.
better use zend_parse_parameters_none()
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP a simple assign expression would raise error, if user use error_get_last() to check they can't guarantee the call site raise the error.
This patch implement a function to clear the error state. There are similar functions like
socket_clear_error().http://php.net/error_get_last
The top voted user contributed note are a tricky way to clear last error.
also there are a lot of apps use the similar hacks.
Request: https://bugs.php.net/bug.php?id=45235