Skip to content

Fix GH-10406: fgets on a redis socket connection fails on PHP 8.3 #11421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-10406: fgets on a redis socket connection fails on PHP 8.3 #11421

wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Jun 10, 2023

This is an alternative implementation for 18fe337 that resets the has_buffered_data flag after finishing stream read so it doesn't impact other ops->read use like for example php_stream_get_line.

pospjan
pospjan reviewed Jun 11, 2023
View reviewed changes
@bukka bukka closed this in 49fbbea Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen left review comments

+1 more reviewer

@pospjan pospjan pospjan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bukka @devnexen @pospjan