Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pdo_sqlite bug_42589.phpt #11494

Closed

Conversation

CViniciusSDias
Copy link
Contributor

Fixing ext/pdo_sqlite/tests/bug_42589.phpt test when ENABLE_COLUMN_METADATA is disabled.

Fixes #11492

@Girgias
Copy link
Member

Girgias commented Jun 21, 2023

Was this only added in PHP 8.3? If not this needs to be backported.

@nielsdos
Copy link
Member

This exists in 8.1 too. So this needs a backport.

In general, you need to create a bugfix PR against the oldest still-supported branch for bugfixes (that has the bug). In this case this would be PHP-8.1 (important: not PHP-8.1.x, just PHP-8.1!)
We then merge the fix upwards to the more recent releases.

@CViniciusSDias CViniciusSDias changed the base branch from master to PHP-8.1 June 21, 2023 22:14
@CViniciusSDias
Copy link
Contributor Author

Got it, @nielsdos

Let me know if that's correct now. :-)

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this looks good now. Thanks!
Upon merging I believe we should credit @KapitanOczywisty too.
I'll do the merge this evening. (unless Girgias beats me to it :p)

@CViniciusSDias
Copy link
Contributor Author

Upon merging I believe we should credit @KapitanOczywisty too.

For sure. This is his fix, to be honest. :-D
Do I need to do something on the PR to credit him?

@nielsdos
Copy link
Member

Upon merging I believe we should credit @KapitanOczywisty too.

For sure. This is his fix, to be honest. :-D
Do I need to do something on the PR to credit him?

No, we add the names during merging. So I can do it.

@nielsdos nielsdos closed this in 039dd0b Jun 22, 2023
@nielsdos
Copy link
Member

Thanks!

@CViniciusSDias CViniciusSDias deleted the test/fix-sqlite-42589-test branch June 22, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test failure: ext/pdo_sqlite/tests/bug_42589.phpt
3 participants