Bug #68669 DateTime::createFromFormat() does not allow NULL $timezone #1167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime::createFromFormat($format, $time, DateTimeZone $timezone = null)
has a default value for its third parameter$timezone
, but it doesn't acceptnull
as a value.Running the following script will raise a warning:
DateTime::createFromFormat('Y/m/d', '2015/1/1', null);
// Warning: DateTime::createFromFormat() expects parameter 3 to be DateTimeZone, null given
While the documentation states that the default timezone is going to be used when no parameter is given, also the case where a
null
$timezone
is given should be handled correctly.This would align the API to the language semantics about default values.