Skip to content

Implement DOMNode::parentElement and DOMNameSpaceNode::parentElement #11679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement DOMNode::parentElement and DOMNameSpaceNode::parentElement #11679

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

Girgias
Girgias approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the readonly thing that needs to be clarified still

ext/dom/php_dom.stub.php
Comment on lines +308 to +310
/** @readonly */
public ?DOMElement $parentElement;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing then in #11677

@nielsdos nielsdos closed this in d04f48b Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias