Fix GH-11716: cli server crashes on SIGINT when compiled with ZEND_RC_DEBUG=1 #11757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
force-pushed
the
fix-cli-rc-debug
branch
from
b0a7b51 to
3a2b824
Compare
|
Of course, immediately after creating a PR I noticed my mistake 🤦 fixed now though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arnaud-lb You talked about thereq->headersandreq->headers_original_casetables having the same problem. However, it doesn't trigger because it seems these hashtables are never used? In that case, maybe we should just remove those hashtables on master? For now, I have left them alone until a decision is taken.EDIT: wait, nvm, they are used, my grep skills failed me... I fixed it now to also mark those tables as persistent local, sorry.
Closes GH-11716.