Skip to content

Conversation

he32
Copy link
Contributor

@he32 he32 commented Mar 19, 2015

Treat NetBSD the same as FreeBSD wrt. TCP_INFO usage.

@laruence
Copy link
Member

as I replied in the bug entry: shouldn't a version checking of NetBSD for since when this was changed also be added as well?

thanks

@he32
Copy link
Contributor Author

he32 commented Mar 19, 2015

I think there's already a test surrounding this code which is dependent
on TCP_INFO being defined, so I don't think that's necessary?

@laruence
Copy link
Member

okey, if you are sure...

@he32
Copy link
Contributor Author

he32 commented Mar 19, 2015

I've at least built on a NetBSD system which doesn't have TCP_INFO with no ill effects.
The surrounding test is ifdef HAVE_LQ_TCP_INFO, although I've not checked how that
is set, but it seems to work as I suspect.

@he32
Copy link
Contributor Author

he32 commented Mar 19, 2015

...and I've also successfully built on a 7.0_BETA system which has TCP_INFO with
this fix in place, so I'm fairly confident the extra test isn't required.

@laruence
Copy link
Member

okey , great. let's wait couple days for some more reviewing...if no then we can merge this "quick fix"

thanks

@php-pulls php-pulls merged commit 36e251a into php:master Mar 22, 2015
@he32 he32 deleted the netbsd-tcp_info branch March 23, 2015 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants