Remove i386 Linux from push #11922
Closed
Remove i386 Linux from push #11922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing this in nightly is sufficient. 32-bit problems are rare.
|
I agree that most of the time 32 bit is not really an issue, but for tweaking core engine code it might be useful to still have the template and to be able to toggle it on when needed? |
|
I looked into triggering pipelines on demand a while back through comments (for performance measuring) but couldn't find a good way to do it. One way to do it could be to modify the title/content and then manually retrigger the CI. To be honest though, I don't think it's necessary. I look at nightly, when there's an issue I can report it. |
|
That's fair, worst case one can always readd the CI run for a specific PR. |
ju1ius
pushed a commit
to ju1ius/php-src
that referenced
this pull request
Aug 15, 2023
Testing this in nightly is sufficient. 32-bit problems are rare. Closes phpGH-11922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this in nightly is sufficient. 32-bit problems are rare.