New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix round() tests for different modes #12049

Merged

bukka merged 2 commits into php:master from jorgsowa:fix-round-tests

Aug 26, 2023

Contributor

jorgsowa commented Aug 25, 2023

Parameter $mode was missing for the test of round() with different mods.

jorgsowa added 2 commits

August 25, 2023 21:56


          Fix tests round() with different modes

6f48e47


          Fix test results for round() with different modes

7aa472c

jorgsowa requested a review from bukka as a code owner

August 25, 2023 20:10

github-actions bot added the Extension: standard label

bukka approved these changes

View reviewed changes

Member

bukka left a comment

Ah completely missed it when reviewing the previous PR. Thanks for the fix.

bukka merged commit 58ae26a into php:master

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment