Skip to content

Fix round() tests for different modes #12049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2023
Merged

Fix round() tests for different modes #12049

merged 2 commits into from
Aug 26, 2023

Conversation

jorgsowa
Copy link
Contributor

Parameter $mode was missing for the test of round() with different mods.

@jorgsowa jorgsowa requested a review from bukka as a code owner August 25, 2023 20:10
bukka
bukka approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah completely missed it when reviewing the previous PR. Thanks for the fix.

@bukka bukka merged commit 58ae26a into php:master Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgsowa @bukka