Fix #69373 References to deleted XPath query results #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment node reference count for nodes created in php_xpath_eval()
|
I tested this patch against your test script (see https://bugs.php.net/bug.php?id=69373) and I'm still getting memory errors from valgrind. |
Prevent double-free from write to nodeValue. xmlNodeSetContentLen calls xmlFreeNode() on the node children. This results in references to those children having pointers to free'ed memory. This fix prevents the call to xmlFreeNode().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increment node reference count for nodes created in php_xpath_eval()