Skip to content

Conversation

iluuu1994
Copy link
Member

Staticness incompatiblity must error before attempting to declare the property.

Staticness incompatiblity must error before attempting to declare the property.
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems.

I wander, if this check makes sense for user classes at all.
Can we eliminate it, adding ce->type == ZEND_INTERNAL_CLASS before the hash lookup?

@iluuu1994
Copy link
Member Author

@dstogov We can't, because zend_declare_typed_property is used from zend_inheritance.c in zend_do_traits_property_binding for user classes.

@iluuu1994 iluuu1994 merged commit f957335 into php:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants