Skip to content

Conversation

nielsdos
Copy link
Member

Some places, possibly also outside PHP, assume the core extension has module number 0. After 8a812c3 this wasn't the case anymore as reported in [1]. Fix it by changing how the next module ID is computed.

[1] #12246 (comment)

Some places, possibly also outside PHP, assume the core extension has
module number 0. After 8a812c3 this wasn't the case anymore as
reported in [1]. Fix it by changing how the next module ID is computed.

[1] php#12246 (comment)
@shivammathur
Copy link
Member

@nielsdos Thanks for fixing it so quickly.

@bukka
Copy link
Member

bukka commented Sep 23, 2023

It would be good to add some test for this so it does not get broken again in the future...

@nielsdos nielsdos merged commit 9b6afd8 into php:master Sep 25, 2023
@sebastianbergmann
Copy link
Contributor

Thank you, @nielsdos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants