ext/xml: Refactor extension to use FCC instead of zvals for handlers #12340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
changed the title
Girgias
force-pushed
the
ext-xml-zval-to-fcc
branch
from
88ad6ff to
01a8927
Compare
|
Related to: php/doc-en#1391 |
|
Pushed fixes, ext/xml tests now pass, but I haven't given this a full review yet (and there's some TODOs, so I'll wait maybe for those) EDIT: this test fails |
Girgias
force-pushed
the
ext-xml-zval-to-fcc
branch
from
1afecb6 to
3c66a18
Compare
Girgias
changed the title
nielsdos
reviewed
Oct 5, 2023
This was referenced Oct 6, 2023
Girgias
force-pushed
the
ext-xml-zval-to-fcc
branch
from
7cd23ae to
e260bd6
Compare
nielsdos
reviewed
Oct 7, 2023
kocsismate
reviewed
Oct 8, 2023
Girgias
force-pushed
the
ext-xml-zval-to-fcc
branch
from
f7a6fd4 to
f9ccae9
Compare
…handlers To get proper errors and sensible behaviour, as the current behaviour is somewhat insane and part of it should be axed ASAP
+ Add failing test
Has heap after free and still need more tests, especially around using proper callables for methods on the same class
Girgias
force-pushed
the
ext-xml-zval-to-fcc
branch
from
f9ccae9 to
edc99d5
Compare
nielsdos
approved these changes
Oct 14, 2023
k00ni
added a commit
to semsol/arc2
that referenced
this pull request
Oct 20, 2023
Use proper callables instead. Related to: php/php-src#12340 Co-authored-by: Konrad Abicht <hi@inspirito.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get proper errors and sensible behaviour, as the current behaviour is somewhat insane and part of it should be axed ASAP
Skipping CI due to known issues and failures regarding the GC and exceptions being swallowed