Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 12424 PDO_PGSQL unit test unexistent variables #12446

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix 12424 PDO_PGSQL unit test unexistent variables #12446

merged 2 commits into from
Oct 16, 2023

Conversation

devnexen
Copy link
Member

No description provided.

@SakiTakamachi
Copy link
Member

Was there a problem?

If you write it this way, the environment variable will not be used, so the test will never pass locally (unless the credentials are the same).

@devnexen
Copy link
Member Author

See here.

SakiTakamachi
SakiTakamachi reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the problem. The method I wrote to obtain the credentials was incorrect.

@devnexen @SakiTakamachi
Update ext/pdo_pgsql/tests/gh12423.phpt
6b9396b 
Co-authored-by: Saki Takamachi <34942839+SakiTakamachi@users.noreply.github.com>
@devnexen devnexen merged commit 4bb7505 into php:master Oct 16, 2023
@SakiTakamachi SakiTakamachi mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakiTakamachi SakiTakamachi SakiTakamachi left review comments

Assignees
No one assigned
Labels
Extension: pdo_pgsql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @SakiTakamachi