PoC patch for bug #69111 #1248
Closed
PoC patch for bug #69111 #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The referenced bug is marked fixed, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PoC patch for bug #69111. I didn't even try to compile it because I think this is not needed.
https://bugs.php.net/bug.php?id=69111
I would rather deprecate use of previous save handler functions as "base" class method for SessionHandler. Session module has too many states already and inheriting previous save handler functions is not mandatory. (I'm going to implement "user serialize handler", so crypt/etc can be done with it for internal save handlers)