Fix infinite loop when mb_detect_encoding is used on UTF-8 BOM #12541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced in cb84079. Thanks to Ignace Nyamagana Butera for discovering this bug and to Sebastian Bergmann for doing an initial investigation and opening a bug ticket.
This was referenced Oct 27, 2023
Girgias
approved these changes
Oct 28, 2023
|
This needs to be backported to 8.3, but otherwise LGTM |
|
Thanks for the review, @Girgias. Just tried building PHP-8.3 with this patch and running tests... dozens of tests failed, including many which are obviously not related. Tried running tests on PHP-8.3 HEAD, it's the same. Looks like someone merged broken code into PHP-8.3. 😢 |
|
Just investigating further on why I am getting all these local test failures. |
|
OK, this was my fault... I had run |
|
Tests are passing. |
|
Merged into PHP-8.3, now merging down into master. |
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in cb84079.
Thanks to Ignace Nyamagana Butera for discovering this bug and to Sebastian Bergmann for doing an initial investigation and opening a bug ticket.
@Girgias @cmb69