return FALSE instead of NULL from ZipArchive::getStream when php_stream_... #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am_zip_open() fails (fixes #67161)
|
Why return false instead of null ? Do we have a consensus about this (I can barely remind something) ? |
|
The documentation of ZipArchive::getStream states that a file handle or false is returned. Returning null usually occurs when a wrong parameter type is given, but that is not the case here. Alternatively, bug #67161 might be changed to doc bug, but it seems to me returning false instead of null is clearer for the user. Of course, returning false instead of null would be a BC break, but probably a very minor one. Note that a failing zip_stat() will already return false, so only if the file exists, but can't be decoded the return value would change. |
|
Merged against master as this would break stable branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...zip_open() fails (fixes #67161)