Remove check for dnet_addr in dnet_stub library #12611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dnet_stub library was once used on some obsolete systems and was needed for transitive linking with Sybase and some PHP extensions. At this point, no known and supported system uses the dnet_stub library name, so it's safe to remove this check. This also came in pdo_dblib as a copy/paste from other removed PHP extensions. Partially was already removed in 1b969a7.
Girgias
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dnet_stub library was once used on some obsolete systems and was needed for transitive linking with Sybase and some PHP extensions. At this point, no known and supported system uses the dnet_stub library name, so it's safe to remove this check. This also came in pdo_dblib as a copy/paste from other removed PHP extensions.
Partially was already removed in 1b969a7.