Fix GH-12618: Changed to specify time zone correctly #12637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
fix/gh-12618
branch
from
1e4ca34
to
528b92b
Compare
iluuu1994
reviewed
Nov 9, 2023
| @@ -38,19 +38,19 @@ function printFormat(int $dateFormat, int $timeFormat, DateTimeImmutable $time) | |||
| } | |||
|
|
|||
| function getToday(): DateTimeImmutable { | |||
| return new DateTimeImmutable(); | |||
| return new DateTimeImmutable("now", new DateTimeZone("America/Los_Angeles")); | |||
There was a problem hiding this comment.
I think you can just do date_default_timezone_set('America/Los_Angeles'); at the top of the file.
There was a problem hiding this comment.
Thank you!
I changed in f834815
|
Thanks @SakiTakamachi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12618