Skip to content

Fix GH-12655: proc_open() does not take into account references in the descriptor array #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-12655: proc_open() does not take into account references in the descriptor array #12658

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

Closes GH-12655

@nielsdos nielsdos linked an issue Nov 12, 2023 that may be closed by this pull request
proc_open(): Argument #2 ($descriptor_spec) must only contain arrays and streams [Descriptor item must be either an array or a File-Handle] #12655
Closed
iluuu1994
iluuu1994 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@nielsdos nielsdos closed this in 86c7d3e Nov 13, 2023
ramsey pushed a commit that referenced this pull request Nov 23, 2023
@nielsdos @ramsey
Fix GH-12655: proc_open() does not take into account references in th…
c376f99 
…e descriptor array

Closes GH-12658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proc_open(): Argument #2 ($descriptor_spec) must only contain arrays and streams [Descriptor item must be either an array or a File-Handle]
2 participants
@nielsdos @iluuu1994