Align error messages between normal VM and JIT for RW when using object as array #12799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Wow, it looks like this error message change was committed to JIT by mistake as it doesn't respect the original VM error message. I don't think these kind of changes should go into stable releases.
I would suggest reverting this JIT change in PHP-8.2 and PHP-8.3 and commit the new message into master only.
It would be also great to add a test case.
dstogov
reviewed
Nov 27, 2023
dstogov
added a commit
that referenced
this pull request
Nov 27, 2023
* PHP-8.2: Align error messages between normal VM and JIT for RW when using object as array (#12799)
dstogov
added a commit
that referenced
this pull request
Nov 27, 2023
* PHP-8.3: Align error messages between normal VM and JIT for RW when using object as array (#12799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the test failure introduced in: 126a255