Add support for upload files from buffer string in curl extenion

[Irker]

Add possible to upload files from string, not from disc.
New function curl_buffer_file_create, similar for curl_file_create, but accept other arguments:
$buffer - file content, $post_filename and $mime_type.
Also CURLFile constructor now haven't required arguments. So we can fill file object later:

$ch = curl_init('http://localhost:8000/server.php');

$file = generate_some_special_image_file(); // just for example, it may be autogenerated pdf, image or something special in memory

$cfile = new CURLFile();
$cfile->setBuffer($file);
$cfile->setPostFilename('test_name.jpg');

$data = array('test_file' => $cfile);
curl_setopt($ch, CURLOPT_POST, 1);
curl_setopt($ch, CURLOPT_POSTFIELDS, $data);

$result = curl_exec($ch);

For BC I save unserialization restriction: if $filename contain string - we cannot unserialize object as before this pull-request. If we have object with buffer unserialization accepted.

If object have $filename we use it and ignore buffer.
$buffer can be empty.

[Kubo2]

@Irker 👍
Does setters return $this?

[Irker]

Hi!
@Kubo2 No, I didn't change methods behavior. I tried to change as less as possible to force pull-request be applied sooner

[smalyshev]

Why you need INTERNAL_FUNCTION_PARAMETERS? You don't seem to use them except for return_value. So maybe just pass return_value?

[Irker]

Thank you, will change it.

[smalyshev]

I am not sure I understand why zval_is_true check? If you wanted to check for name being empty/null, then it should be that check. Otherwise you'll get in trouble with "0" etc.

[Irker]

@smalyshev , can it be something like if (!Z_ISNULL_P(prop) && (Z_TYPE_P(prop) != IS_STRING || Z_STRLEN_P(prop) > 0)) { ? Not sure if prop can be ISUNDEF after zend_read_property. Can you correct me, before I will push this change?

[smalyshev]

Not sure it can be UNDEF, but I'd rather specify explicitly which values we do expect - i.e. if we expect name to be NULL when we use buffer.

Also, whatever check you do here you should also do on __wakeup. In fact, I'd make it a macro or inline function to ensure they are always the same.

[Irker]

If we will use NULL as base value for this condition, we must change this code: zend_declare_property_string(curl_CURLFile_class, "name", sizeof("name")-1, "", ZEND_ACC_PUBLIC); to zend_declare_property_null. This is small but BC break =(, because we change default value for property.

Previous variant of pull-request with separate CURLBufferFile seems now less terrible )))

[Irker]

Not interested for the community

[Irker]

@smalyshev is any chance to implement sending files from buffer string?
I can try to create new PR, but all tries broken by current realisation:

1. If I tried to separate feature to another class we have many duplicates codes
2. If I tried to add feature to current class we have many logic problems discussed in this PR.
3. If I tried to create two new immutable classes we have too big BC and need support new and old ways. (Same as previous "@filename" option) .
   This feature require only few strings of code for CURL library, and very usefull for production.

[smalyshev]

@Irker I'll look into it.

[Irker]

@smalyshev I do not want to disturb, but I think it's time to remind.