Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented May 27, 2015

This patch is supposed to solve whitespace depending irregularities when iterating over SimpleXMLElements where sxe.iter_type == SXE_ITER_NONE. The faulty behavior may affect var_dump, print_r, json_encode, etc.

Of course, the patch addresses the duplicates #62639, #67116, #69169, #69491, #61335 and #67572 as well; nonetheless there are separate tests included, based on the respective test scripts, for each of the mentionend reports. Tests for #66084 had already been merged.

I've tested the patch on Windows 7 (libxml2 2.9.2) and Ubuntu 14.04 LTS (libxml2 2.7.7, 2.7.8, 2.8.0, 2.9.1 and 2.9.2) with PHP 5.5.25, PHP 5.6.9 and master (7dac4d4). Before applying the actual patch the 6 new tests failed; after applying the patch all tests in ext/simplexml/tests passed,except very few tests which also did not pass without the patch: SimpleXMLElement_xpath.phpt and bug37565.phpt on Windows with PHP 5, and SimpleXMLElement_xpath.phpt on Ubuntu (skipped due to requiring 32-bit build) with master.

It has to be noted that commit 18f9589 is not relevant for PHP 5, but only for current master.

@php-pulls
Copy link

Comment on behalf of ab at php.net:

Thanks, merged in master. To be backported into 5.5 and 5.6

@php-pulls php-pulls closed this May 29, 2015
@cmb69 cmb69 deleted the sxe-var-dump branch July 12, 2015 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants