Add support for bitwise string assign ops #1322
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$str[$off] OP= $x;
equivalent to$str[$off] = $str[$off] OP $x;
Fixes fatal error for |=, ^= and &= on string offsets. Other people may feel free to add support for other ops, but I don't see any real sense in it (at least as long as we require the equality above to hold).
Changing that would need a RFC, hence this PR is only strictly doing what it does on e.g. array access too.