Fix GH-13193: Significant performance degradation in 'foreach' starting from PHP 8.2.13 (caused by garbage collection) #13265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting from PHP 8.2.13 (caused by garbage collection)
iluuu1994
approved these changes
Jan 29, 2024
Zend/zend_gc.c
Outdated
|
|
||
| ZEND_API int zend_gc_collect_cycles(void) | ||
| { | ||
| int total_count = 0; | ||
| bool should_rerun_gc = 0; | ||
| bool did_rerun_gc = 0; | ||
|
|
||
| zend_gc_remove_root_tmpvars(); |
There was a problem hiding this comment.
Can this be moved into the if below? Preferably after if (GC_G(gc_active)) { so that this doesn't run twice when GC isn't even active.
Edit: It would only run once since the check returns. Might be fine if it can remove some elements from the buffer I suppose.
There was a problem hiding this comment.
It make sense to wrap this call with if (GC(active) && GC_G(num_roots)).
Moving the call down is not a good idea because of rerun_gc label.
nielsdos
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.