Fix bug #61221 - imagegammacorrect function loses alpha channel #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying imagegammacorrect() the alpha channel is now fully retained, instead of being completely lost.
|
Thx for the patch! Exactly what is needed (gamma correction should not be applied to alpha, for the record) Should be applied to 5.5+,go ahead :) |
I can't merge it myself; I don't have php-src karma. |
|
Comment on behalf of cmb at php.net: Applied to PHP 5.5+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying imagegammacorrect() the alpha channel is now fully retained, instead of being completely lost.
I've tested this on Windows 7 and Ubuntu 14.04 (bundled GD lib only).
@pierrejoye @remicollet Please have a look at this PR. The patch seems to be straight forward, and I don't expect it to be a real BC break, because likely nobody used imagegammacorrect() on images with alpha channel (at least without manual correction). At least this might be merged into master for PHP 7.