Skip to content

Remove inet_aton function #13479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Remove inet_aton function #13479

wants to merge 15 commits into from

Conversation

jorgsowa
Copy link
Contributor

Removes function inet_aton. Implemented suggestion from #13410 (comment)

petk
petk reviewed Feb 22, 2024
View reviewed changes
Girgias
Girgias approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petk do you think we need to mention in upgrading internals that we do not check of this function nor define HAVE_INET_ATON any more?

@petk
Copy link
Member

petk commented Feb 23, 2024

@petk do you think we need to mention in upgrading internals that we do not check of this function nor define HAVE_INET_ATON any more?

Yes, we can add it. Otherwise, I'll note it in the future with simplifications of those build system UPGRADING.INTERNAL part in one paragraph.

devnexen
devnexen approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplification.

@jorgsowa
Copy link
Contributor Author

Thank you all for the reviews.

@petk, I have added an entry to UPGRADING.INTERNALS.

@petk petk closed this in 9c4beac Feb 23, 2024
@petk
Copy link
Member

petk commented Feb 23, 2024

Thanks @jorgsowa added to master (PHP-8.4-dev) branch.

@jorgsowa jorgsowa deleted the remove_inet_aton branch June 13, 2024 21:43
@cmb69 cmb69 mentioned this pull request Aug 24, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petk petk petk left review comments

@devnexen devnexen devnexen approved these changes

@Girgias Girgias Girgias approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: sockets Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgsowa @petk @devnexen @Girgias