Optimize php_html_entities()

[yohgaki]

Current php_html_entities() convert int/float/etc to string, then convert it.
int/float/etc is not required to be escaped. Optimize it by simply converting them to string.

Simple benchmark shows about 60% execution time reduction.

[yohgaki@dev github-php-src]$ ./php-bin b.php
Time: 10.484607934952
[yohgaki@dev github-php-src]$ ./php-bin b.php
Time: 10.867615222931
[yohgaki@dev github-php-src]$ ./php.new b.php
Time: 3.9379420280457
[yohgaki@dev github-php-src]$ ./php.new b.php
Time: 4.0694711208344
[yohgaki@dev github-php-src]$ cat b.php

[laruence]

as I replied via mail, just for the record:
"But passing an non-string to htmlspecialchars are not common used cases..

"optimize" not common used cases... will bring nothing to us.. "

[yohgaki]

@laruence
It will not be rare since PHP7 has scalar type hint. There are many cases users must output width, height, age, month, numeric ID, etc.
BTW, I noticed that current test script didn't consider scalar value parameter well and the patch has problem with it. I'll fix if we decide to have this optimization.

[nikic]

Closing as the reception of this change on the mailing list was clearly negative.

For reference: http://markmail.org/message/dmggiip2vhaqxmqu