Skip to content

Conversation

Ayesh
Copy link
Member

@Ayesh Ayesh commented Mar 2, 2024

  • Moved curl_version()['feature_list'] to New Features
  • Moved NumberFormatter::ROUND_HALFODD to New Features
  • Removed contributor names (this pattern only used in the NEWS file)

UPGRADING Outdated
- PDO_DBLIB:
. Fixed setAttribute and getAttribute (SakiTakamachi)
. Added PdoDbLib class (danack, kocsismate)
. Fixed setAttribute and getAttribute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry is actually a bit vague. I see it corresponds to #12793
However, that PR did already add an entry for this in the BC section, so this might not be necessary...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I removed that line.

 - Moved curl_version()['feature_list'] to New Features
 - Moved NumberFormatter::ROUND_HALFODD to New Features
 - Removed contributor names (this pattern only used in the `NEWS` file)
 - Removed "Fixed setAttribute and getAttribute" as it is covered in another change record
@Ayesh Ayesh force-pushed the UPGRADING_minor-fixes branch from 393239b to 3258ec5 Compare March 2, 2024 18:28
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@nielsdos nielsdos merged commit 1b380d6 into php:master Mar 2, 2024
@Ayesh Ayesh deleted the UPGRADING_minor-fixes branch March 12, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants