Skip to content

Segmentation fault on pdo_dblib::nextRowset (bug #69757) #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Segmentation fault on pdo_dblib::nextRowset (bug #69757) #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c038c2e
Segmentation fault on pdo_dblib::nextRowset (bug #69757)
MiRacLe-RPZ Jul 3, 2015
87e4bf3
testcase fot bug #69757
MiRacLe-RPZ Jul 6, 2015
5bd30c9
dblib's dbcolname can return null in some cases
MiRacLe-RPZ Sep 2, 2015
b593eec
use spprintf instead (no need to estrdup afterwards).
MiRacLe-RPZ Oct 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ext/pdo_dblib/dblib_stmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,16 @@ static int pdo_dblib_stmt_describe(pdo_stmt_t *stmt, int colno TSRMLS_DC)
}

struct pdo_column_data *col = &stmt->columns[colno];

col->name = (char*)dbcolname(H->link, colno+1);

char *fname = (char*)dbcolname(H->link, colno+1);

if (fname && *fname) {
col->name = estrdup(fname);
col->namelen = strlen(col->name);
} else {
col->namelen = spprintf(&col->name, NULL, "computed%d", colno);
}
col->maxlen = dbcollen(H->link, colno+1);
col->namelen = strlen(col->name);
col->param_type = PDO_PARAM_STR;

return 1;
Expand Down
32 changes: 32 additions & 0 deletions ext/pdo_dblib/tests/bug_69757.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
--TEST--
PDO_DBLIB: Segmentation fault on pdo_dblib::nextRowset
--SKIPIF--
<?php
if (!extension_loaded('pdo_dblib')) die('skip not loaded');
require __DIR__ . '/config.inc';
?>
--FILE--
<?php
require __DIR__ . '/config.inc';

$sql = "
exec dbo.sp_executesql N'
SELECT * FROM sysobjects
SELECT * FROM syscolumns
'
";
$stmt = $db->query($sql);
$resultset1 = $stmt->fetchAll(PDO::FETCH_ASSOC);
if (true !== $stmt->nextRowset()) {
die('expect TRUE on nextRowset');
}
$resultset2 = $stmt->fetchAll(PDO::FETCH_ASSOC);
if (false !== $stmt->nextRowset()) {
die('expect FALSE on nextRowset');
}
$stmt->closeCursor();

echo "OK\n";
?>
--EXPECT--
OK