Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sapi/cgi: fix buffer limit on windows. #14022

Closed
wants to merge 2 commits into from
Closed

sapi/cgi: fix buffer limit on windows. #14022

wants to merge 2 commits into from

Conversation

devnexen
Copy link
Member

MSDN recommends dropping the deprecated read in favor of _read. Also, the buffer size limit is INT_MAX.

@devnexen
sapi/cgi: fix buffer limit on windows.
370a1e8 
MSDN recommends dropping the deprecated `read` in favor of `_read`.
Also, the buffer size limit is INT_MAX.
@devnexen devnexen marked this pull request as ready for review April 20, 2024 20:00
@devnexen devnexen requested a review from bukka as a code owner April 20, 2024 20:00
@devnexen devnexen requested a review from nielsdos April 30, 2024 22:43
nielsdos
nielsdos approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right.
We had a similar problem in ext/standard a while ago.

@devnexen devnexen closed this in 7484394 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
SAPI: cgi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos