ext/hash: Swap the checking order of __has_builtin and __GNUC__ #14185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
May 9, 2024
ext/hash: Swap the checking order of __has_builtin and __GNUC__
SakiTakamachi
force-pushed
the
fix_hash_define_bswap
branch
from
ede4152 to
7017efe
Compare
SakiTakamachi
added a commit
that referenced
this pull request
May 10, 2024
* PHP-8.2: ext/hash: Swap the checking order of __has_builtin and __GNUC__ (#14185)
SakiTakamachi
added a commit
that referenced
this pull request
May 10, 2024
* PHP-8.3: ext/hash: Swap the checking order of __has_builtin and __GNUC__ (#14185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
__has_builtinis defined and__has_builtin(__builtin_bswap64)isfalse,__GNUC__is not used even if it is defined.