Sync -Wno-implicit-fallthrough #14187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
approved these changes
May 13, 2024
|
What are the warnings without this flag? Ideally for ext/date and lib, this should be warning free. |
For the ext/date, I wasn't able to reproduce the warning. Even on very old commits from PHP-8.2. It seems that this fallthrough warning in ext/date was happening on one of the CI machines back then but now it seems to be working ok with removing this flag. I think something was fixed in the meantime in the timelib. Tested on 32-bit and 64-bit... |
petk
force-pushed
the
patch-implicit-fallthrough
branch
from
7f82cf6
to
760477f
Compare
petk
added a commit
that referenced
this pull request
Jun 8, 2024
This is a sync of the #6252 after few years: - ext/date: pending recheck in GH-14187 - ext/hash: warning happens only on 32-bit build in ext/hash/sha3/generic32lc/KeccakP-1600-inplace32BI.c - ext/opcache: IR JIT doesn't seem to have this issue - ext/pcre remains disabled due to pcre2lib/sljit/sljitNativeARM_64.c (should be rechecked and fixed upstream)
petk
force-pushed
the
patch-implicit-fallthrough
branch
from
760477f
to
10c770c
Compare
|
ext/opcache and ext/hash have been synced in 743d1fd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sync of the #6252 after few years:
fixed since derickr/timelib@f8caaefEdited: wrong commit pasted, flag was removed in one of the commitsAnd I'm also checking CI how it looks.