Fix #53156: imagerectangle problem with point ordering

[cmb69]

Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left and the lower right
corner, respectively. However, libgd already caters to upper right / lower left
pairs, and not catering to the other two combinations seems to be an oversight.

Reported upstream.

IMHO the patch should be applied to PHP 5.6, too. @pierrejoye @remicollet Any objections?

[pierrejoye]

Yes, making the whole thing more consistent sounds like a sane move

Thanks!
On Jul 20, 2015 7:34 AM, "Christoph M. Becker" notifications@github.com
wrote:

Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left and the lower
right
corner, respectively. However, libgd already caters to upper right / lower
left
pairs, and not catering to the other two combinations seems to be an
oversight.

Reported upstream libgd/libgd#177.

IMHO the patch should be applied to PHP 5.6, too. @pierrejoye
https://github.com/pierrejoye @remicollet

https://github.com/remicollet Any objections?

You can view, comment on, or merge this pull request online at:

#1425
Commit Summary

• Fix #53156: imagerectangle problem with point ordering

File Changes

• M ext/gd/libgd/gd.c
  https://github.com/php/php-src/pull/1425/files#diff-0 (4)
• A ext/gd/tests/bug53156.phpt
  https://github.com/php/php-src/pull/1425/files#diff-1 (59)

Patch Links:

• https://github.com/php/php-src/pull/1425.patch
• https://github.com/php/php-src/pull/1425.diff

—
Reply to this email directly or view it on GitHub
#1425.

[cmb69]

Yes, making the whole thing more consistent sounds like a sane move

Great! I'm going to merge to PHP 5.6 and master soon.

[php-pulls]

Comment on behalf of cmb at php.net:

Merged.