Fix #36365: scandir duplicates file name at every 65535th file #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to DIR.offset being declared as short we have an overflow. This patch changes the field to int.
|
Comment on behalf of cmb at php.net: Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to DIR.offset being declared as short we have an overflow. This patch
changes the field to int.
unsigned int seems to be more logical, but as it was signed before, I didn't want to change that. The change from short to int increases the size of DIR on 32bit systems, but that seems to be neglectable (DIR is a large structure, anyway), so it seems a bitfield is unnecessary.
Anyhow, this patch is an ABI break, and as such is most likely unsuitable for PHP 5.6, unfortunately.
I have not added a regression test, because that would be a very slow test, and I consider it highly unlikely that somebody will revert the field to short in the future.
PS: the bug as well as this patch affects Windows only.