Improve open/close tag handling for phpdbg + stdin #14773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems my fix didn't work, and it wasn't immediately obvious to me why. Hence, I won't be pursuing this. Sorry @devnexen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @devnexen
phpdbg currently always compiles scripts with the
ZEND_COMPILE_POSITION_AFTER_OPEN_TAGflag. To allow loading scripts through stdin that start with<?php, it would prepend a?>to the source. This would implicitly turn into?>into;, which are not allowed beforedeclare(strict_types=1).