PHP mysqlnd must activate TCP keep-alive when connecting to a server #1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP mysqlnd extension must do the same to maintain compatibility.
|
This is the proposed fix for bug #70456. |
|
@cmb69, if you wanna merge it then go ahead for 5.6 & master, both green light. |
|
@KalleZ I haven't checked the patch. I merely noticed that the issue had been reported in the bug tracker, and so I added a reference to the report. :) I suggest that somebody reviews the PR and commits, if appropriate. |
|
Comment on behalf of cmb at php.net: Applied. Thanks, Sergei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to maintain compatibility with libmysqlclient.