Skip to content

ext/pdo_firebird: Do not implement new constants in PDO core #14995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

ext/pdo_firebird: Do not implement new constants in PDO core #14995

merged 1 commit into from
Jul 17, 2024

Conversation

SakiTakamachi
Copy link
Member

  • FB_TRANSACTION_ISOLATION_LEVEL
  • FB_READ_COMMITTED
  • FB_REPEATABLE_READ
  • FB_SERIALIZABLE
  • FB_WRITABLE_TRANSACTION

These constants were added for 8.4. Implement these only in subclasses.

@SakiTakamachi SakiTakamachi requested review from Girgias and cmb69 July 17, 2024 15:45
Girgias
Girgias approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It indeed makes more sense to have them on the dedicated driver :)

cmb69
cmb69 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me too. Thank you!

@SakiTakamachi
Copy link
Member Author

Thx!

@SakiTakamachi SakiTakamachi merged commit 4cb82b0 into php:master Jul 17, 2024
11 checks passed
@SakiTakamachi SakiTakamachi deleted the fix/firebird_const branch July 17, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: pdo_firebird
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SakiTakamachi @cmb69 @Girgias