Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #70465 - LDAP functions clobbered TIMELIMIT and DEREF options in ldap_search #1512

Conversation

5 participants
@TysonAndre
Copy link
Contributor

commented Sep 8, 2015

LDAP_OPT_TIMELIMIT and LDAP_OPT_DEREF's original values weren't
saved properly because of a bug introduced when copy and pasting.

This lead to the original timeout being changed
when specifying a temporary override (e.g. for ldap_search(..., $timeout))

Added a test which should fail for the original code (haven't executed it yet)

@mishan

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2015

Nice find! 👍

@TysonAndre TysonAndre force-pushed the TysonAndre:ldap-fix-saving-timeout-and-dereference branch from ae9dd49 to 564862a Sep 9, 2015

Tyson Andre
Fix bug in LDAP extensions' saving TIMELIMIT and DEREF
LDAP_OPT_TIMELIMIT and LDAP_OPT_DEREF's original values weren't
saved properly because of a bug introduced when copy and pasting.

This lead to the original timeout being changed
when specifying a temporary override (e.g. for ldap_search(..., $timeout))

@TysonAndre TysonAndre force-pushed the TysonAndre:ldap-fix-saving-timeout-and-dereference branch from 564862a to c3fc65e Sep 9, 2015

@TysonAndre TysonAndre changed the title Fix a bug in LDAP functions restoring TIMELIMIT and DEREF when temporarily overriding Fix bug #70465 - LDAP functions clobbered TIMELIMIT and DEREF options in ldap_search Sep 9, 2015

@MCMic

This comment has been minimized.

Copy link

commented Sep 9, 2015

I merged it in 5.6 and master but branch PHP-5.5 is closed so it refuses.

@MCMic

This comment has been minimized.

Copy link

commented Sep 9, 2015

Ok, PHP-5.5 is closed because it’s in the «Security fixes only» state: http://php.net/supported-versions.php
This does not seem like a security issue, so the PR can be closed IMO. (seems I don’t have enough rights to do so)

@heiglandreas

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2015

@jpauli @dsp Can one of you close this issue? Thanks!

@laruence laruence closed this Sep 9, 2015

@heiglandreas

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2015

Thanks @laruence!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.