Fix bug #70465 - LDAP functions clobbered TIMELIMIT and DEREF options in ldap_search #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! 👍 |
TysonAndre
force-pushed
the
ldap-fix-saving-timeout-and-dereference
branch
from
ae9dd49 to
564862a
Compare
LDAP_OPT_TIMELIMIT and LDAP_OPT_DEREF's original values weren't saved properly because of a bug introduced when copy and pasting. This lead to the original timeout being changed when specifying a temporary override (e.g. for ldap_search(..., $timeout))
TysonAndre
force-pushed
the
ldap-fix-saving-timeout-and-dereference
branch
from
564862a to
c3fc65e
Compare
TysonAndre
changed the title
|
I merged it in 5.6 and master but branch PHP-5.5 is closed so it refuses. |
|
Ok, PHP-5.5 is closed because it’s in the «Security fixes only» state: http://php.net/supported-versions.php |
|
Thanks @laruence! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDAP_OPT_TIMELIMIT and LDAP_OPT_DEREF's original values weren't
saved properly because of a bug introduced when copy and pasting.
This lead to the original timeout being changed
when specifying a temporary override (e.g. for ldap_search(..., $timeout))
Added a test which should fail for the original code (haven't executed it yet)