Skip to content

Autotools: Replace PHP_EXT_DIR with $ext_dir #15133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2024
Merged

Autotools: Replace PHP_EXT_DIR with $ext_dir #15133

merged 1 commit into from
Jul 28, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 28, 2024

  • Sync Autoconf syntax
  • The PHP_EXT_DIR macro doesn't accept any arguments and since this is called after PHP_NEW_EXTENSION, the $ext_dir variable can be used instead.

@petk
Autotools: Replace PHP_EXT_DIR with $ext_dir
6ef4d2b 
- Sync Autoconf syntax
- The PHP_EXT_DIR macro doesn't accept any arguments and since this is
  called after PHP_NEW_EXTENSION, the $ext_dir variable can be used
  instead.
@petk petk requested a review from devnexen as a code owner July 28, 2024 02:45
devnexen
devnexen approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk petk merged commit 590786a into php:master Jul 28, 2024
9 of 11 checks passed
@petk petk deleted the patch-PHP_EXT_DIR-intl branch July 28, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen