Set XML_PARSE_HUGE by default when using XML_Parser #1515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The restriction is for DoS protection. I think this options should be a setting. Perhaps, new INI for this? |
|
It cannot be the default as @yohgaki has pointed out. Since we don't like adding configuration options, I'd prefer if you could set this from PHP somehow. @camporter please review and rework the patch :) |
|
Not sure which apis use this method overall, but I would e.g. add a Flag/Option in http://php.net/manual/en/xmlreader.xml.php |
|
Having waited more than a month for feedback, and having received nothing, I'm closing this PR as it would appear abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to letting the XML parser handle documents larger than 10 MB, which is a restriction set by libxml.
Addresses https://bugs.php.net/bug.php?id=65604