Autotools: Sync CS in opcache extension #15340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Aug 11, 2024
petk
commented
- AS_* macros used
- Overquoted AC_RUN_IFELSE macros arguments reduced
- Redundant double quoted single variables assignments removed
- AS_* macros used - Overquoted AC_RUN_IFELSE macros arguments reduced - Redundant double quoted single variables assignments removed
devnexen
reviewed
Aug 11, 2024
ext/opcache/config.m4
Outdated
| ;; | ||
| i[[34567]]86*) | ||
| ], | ||
| [[i[34567]86*]], [ |
There was a problem hiding this comment.
quick question: can this condition and the next be merged in one ?
There was a problem hiding this comment.
Of course. Yes, good catch finding this one. Joined in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.