OpCache Windows bug fix #1536
OpCache Windows bug fix #1536
Conversation
Fix for the OpCache issue reported as: zendtech/ZendOptimizerPlus#167 and possibly several bugs on bugs.php.net
This reverts commit 558e31f.
This reverts commit 892b0b7.
This reverts commit c258467.
Merge remote-tracking branch 'upstream/master' Conflicts: ext/opcache/shared_alloc_win32.c
| @@ -288,3 +288,4 @@ win32/*.positions | |||
| win32/ext | |||
| win32/phpts.def | |||
| win32/wsyslog.h | |||
| ext/opcache/shared_alloc_win32.c | |||
There was a problem hiding this comment.
I guess this .gitignore change isn't intentional here...?
There was a problem hiding this comment.
No that is not an intentional change.
Please fix.
Thanks
-M
From: Bob Weinand notifications@github.com
Sent: Monday, October 5, 2015 4:11:07 PM
To: php/php-src
Cc: Matt Ficken (Insight Global)
Subject: Re: [php-src] OpCache Windows bug fix (#1536)
In .gitignorehttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fphp%2fphp-src%2fpull%2f1536%23discussion_r41209590&data=01%7c01%7cv-mafick%40microsoft.com%7c18eec26a3c5742057c8308d2cdda421e%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ThT9uLdQWHq0vVYTF2YuihW6H95Nsigi0TIhSAhKo6E%3d:
@@ -288,3 +288,4 @@ win32/*.positions
win32/ext
win32/phpts.def
win32/wsyslog.h
+ext/opcache/shared_alloc_win32.c
I guess this .gitignore change isn't intentional here...?
Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fphp%2fphp-src%2fpull%2f1536%2ffiles%23r41209590&data=01%7c01%7cv-mafick%40microsoft.com%7c18eec26a3c5742057c8308d2cdda421e%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uIIXcgNhudUPdE6bWh8CZXTHVbT7Ej72lkLjBtdSryc%3d.
IPC between processes to avoid consistency problems between normal OpCache processes and processes storing their side-step OpCaches on their private heap.
|
Looks like now with the file cache fallback implementation in 7.0, this ticket became obsolete. Probably should be just closed? Thanks. |
|
Yes. From: Anatol Belski notifications@github.com Looks like now with the file cache fallback implementation in 7.0, this ticket became obsolete. Probably should be just closed? Thanks. Reply to this email directly or view it on GitHubhttps://github.com//pull/1536#issuecomment-163252843. |
|
Comment on behalf of ab at php.net: Obsolete with file cache fallback implementation in ffb5d0a |
Just by unlocking around Sleep() the OpenFileMapping loop will work. Holding the lock in that loop will not only block detach_segments() but will also block other PHPs from reattaching in accel_startup().
Checking the base address used when this issue occurs during some of my stress testing, most of the time the base address used is the first in vista_mapping_base_set.
This is the same/similar issue as the Apache2 issue described in the note for that loop. Unlocking around Sleep() fixes the majority of this issue.